Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new custom role permissions, allow GET to retrieve MemberRole #1908

Merged
merged 2 commits into from Apr 5, 2024

Conversation

PatrickRice-KSC
Copy link
Contributor

@PatrickRice-KSC PatrickRice-KSC commented Apr 3, 2024

This PR adds support for several new custom role permissions. It also resolves an issue where you could previous add or update customer roles, but you would be unable to read them from the API after they were set.

  • Update GroupMember to include MemberRole, allowing the GET APIs to retrieve the custom roles

  • Add the following new Permissions

    • Admin CI/CD Variables
    • Admin Terraform States
    • Admin Group Members
    • Manage Group Access Tokens
    • Archive Projects
    • Remove Projects
  • Fixed typos in the JSON tags for 2 permissions

    • Manage Project Access Tokens (wasn't plural, should have been)
    • Admin Merge Requests (was plural, shouldn't have been)

There is one additional permission in the example JSON I got from the API (admin_push_rules) that I didn't include, because it's not documented in the member roles documentation yet: https://docs.gitlab.com/ee/api/member_roles.html

@PatrickRice-KSC
Copy link
Contributor Author

@svanharmelen - This PR is ready for your review!

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickRice-KSC 👍🏻

@svanharmelen svanharmelen merged commit 1ccfef0 into xanzy:main Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants