Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to SetDroneCIServiceOptions #1886

Merged

Conversation

jmajaca
Copy link

@jmajaca jmajaca commented Feb 24, 2024

This PR adds a missing push_events, merge_requests_events and tag_push_events to SetDroneCIServiceOptions.

GitLab API docs: https://docs.gitlab.com/ee/api/integrations.html#set-up-drone

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Thanks @jmajaca!

@svanharmelen svanharmelen force-pushed the drone-integration-missing-set-fields branch from 2132289 to 2f95cf4 Compare February 25, 2024 09:18
@svanharmelen svanharmelen merged commit d276988 into xanzy:main Feb 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants