Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Merge comment event #1694

Merged
merged 6 commits into from Apr 14, 2023
Merged

Conversation

smit-modi
Copy link
Contributor

Added TestMergeCommentEventUnmarshal

Also, added missing fields MergeCommentEvent.EventType, MergeCommentEvent.Project.ID, MergeCommentEvent.MergeRequest.Labels, MergeCommentEvent.MergeRequest.Asignee, MergeCommentEvent.MergeRequest.DetailedMergeStatus

}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to end the last line with a newline char...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@smit-modi smit-modi changed the title Merge comment event Updated Merge comment event Apr 13, 2023
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@svanharmelen svanharmelen merged commit 2d13628 into xanzy:master Apr 14, 2023
3 checks passed
@smit-modi smit-modi deleted the merge-comment-event branch April 14, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants