Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Commit comment event #1688

Merged
merged 2 commits into from Apr 14, 2023
Merged

Conversation

smit-modi
Copy link
Contributor

@svanharmelen Looking for a review

Description string `json:"description"`
URL string `json:"url"`
StDiff *Diff `json:"st_diff"`
Description string `json:"description"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this field in the docs...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't modified the Description field, it was already there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only changed StDiff's type with *Diff

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check... I'll take it 👍🏻

@svanharmelen svanharmelen merged commit 18f63c6 into xanzy:master Apr 14, 2023
3 checks passed
@smit-modi smit-modi deleted the commit-comment-event branch April 14, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants