New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Group SAML Links #1527
Add Group SAML Links #1527
Conversation
Downstream Terraform Provider Update: gitlabhq/terraform-provider-gitlab#1215 |
// | ||
// GitLab API docs: | ||
// https://docs.gitlab.com/ee/api/groups.html#list-saml-group-links | ||
func (s *GroupsService) ListGroupSAMLLinks(gid interface{}, options ...RequestOptionFunc) ([]*SAMLGroupLink, *Response, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this endpoint support pagination?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, just confirmed with live testing in Postman.
I've just created a MR upstream on GitLab to improve a few things for this API, seehttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/95561 - including:
|
@mhodgson little update: my MR to the API from this morning was merged a few hours ago. Thus, I think you can implement it accordingly :) |
@timofurrer awesome! Do you know when this would be in production? We're hoping to use this sooner than later... |
@timofurrer I updated the code here to account for your upstream changes. |
@mhodgson It's already available on gitlab.com, see: https://docs.gitlab.com/ee/api/groups.html#get-saml-group-link And it will come to the self-hosted version with GitLab 15.3 - which means that I'll try to get a release out of the terraform provider on either the 22nd or 23rd - right after 15.3 comes out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉
@timofurrer are you sure the changes are live? I'm testing the create endpoint and still getting a |
Interesting 🤔 I just assumed because the docs are live - it must be available "soon" ™️ |
@timofurrer looks like the updates are live! LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR requires a few small tweaks which I will add in a separate commit...
While working on gitlabhq/terraform-provider-gitlab#1215 I have noticed that the access level type introcued in xanzy#1527 is wrong.
While working on gitlabhq/terraform-provider-gitlab#1215 I have noticed that the access level type introcued in xanzy#1527 is wrong.
While working on gitlabhq/terraform-provider-gitlab#1215 I have noticed that the access level type introcued in xanzy#1527 is wrong.
Gitlab Group SAML Group links added to production API yesterday:
https://docs.gitlab.com/ee/api/groups.html#saml-group-links