Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing certifiate -> certificate in Pages domain #1452

Merged
merged 1 commit into from Apr 18, 2022
Merged

Fixing certifiate -> certificate in Pages domain #1452

merged 1 commit into from Apr 18, 2022

Conversation

nagyv
Copy link
Contributor

@nagyv nagyv commented Apr 17, 2022

There is a typo in the Pages domain options. As a result, the API returns a 400 error:

{
 "error": "user_provided_certificate, user_provided_key provide all or none of parameters"
}

@nagyv nagyv mentioned this pull request Apr 17, 2022
Closed
1 task
svanharmelen
svanharmelen approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks @nagyv 👍🏻

@svanharmelen svanharmelen merged commit 862ba3a into xanzy:master Apr 18, 2022
@nagyv
Copy link
Contributor Author

nagyv commented Apr 19, 2022 •
edited

@svanharmelen Thanks! Could you create a new release to unblock gitlabhq/terraform-provider-gitlab#1026?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timofurrer timofurrer timofurrer approved these changes

@svanharmelen svanharmelen svanharmelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nagyv @timofurrer @svanharmelen