Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide gitlab_pages_domain resource #1026

Closed
wants to merge 25 commits into from
Closed

Conversation

nagyv
Copy link
Collaborator

@nagyv nagyv commented Apr 17, 2022

Description

Create a gitlab_pages_domain resource

Closes #498

Blocked by xanzy/go-gitlab#1452

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation. ✅
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource ✅
      • Update the attributes ✅
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.) ✅

@github-actions github-actions bot added provider resource Adds or modifies a resource tests size/L labels Apr 17, 2022
@nagyv
Copy link
Collaborator Author

nagyv commented Apr 17, 2022

I expect the tests to fail for now. I run into two issues with the tests:

  1. Running make testacc RUN=TestAccGitlabPagesDomain_basic returns error 404
  2. Running make testacc RUN=TestAccGitlabPagesDomain_basic GITLAB_TOKEN=glpat-xxx GITLAB_BASE_URL=https://gitlab.com returns error 400.

The latter led to xanzy/go-gitlab#1452

Why was there a different error in GitPod? Are GitLab pages enabled in GitPod?

@nagyv nagyv self-assigned this Apr 17, 2022
@PatrickRice-KSC
Copy link
Collaborator

Hey @nagyv , yeah, pages isn't configured in the docker-compose/makefile yet. We could potentially add a new wildcard cert to the ones generated by openssl (should probably wait until we merge #1023 so we can build on top of the work shock is doing), which seems to be a pre-req for enabling pages based on: https://docs.gitlab.com/ee/administration/pages/index.html#configuration

image

@timofurrer
Copy link
Member

FYI @PatrickRice-KSC @nagyv I've merged #1023 🎉

@github-actions github-actions bot added documentation tools merge-conflict PR cannot be merged due to a merge conflict labels Apr 18, 2022
@github-actions
Copy link

This pull request has merge conflicts. Please rebase your branch onto main.

@github-actions github-actions bot removed documentation merge-conflict PR cannot be merged due to a merge conflict labels Apr 18, 2022
@github-actions
Copy link

Conflicts are resolved. Thank you! 😀

@github-actions
Copy link

Conflicts are resolved. Thank you! 😀

@github-actions github-actions bot removed merge-conflict PR cannot be merged due to a merge conflict dependencies tools labels May 22, 2022
@github-actions
Copy link

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

@github-actions
Copy link

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

@github-actions
Copy link

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

@github-actions
Copy link

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

@github-actions
Copy link

Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the stale label.

To help this pull request get reviewed, please check that it is rebased onto the latest main and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist.

@github-actions github-actions bot added the stale label Oct 26, 2022
@timofurrer timofurrer added the needs-rebase For PRs which need a rebase label Nov 2, 2022
@github-actions github-actions bot removed the stale label Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Thank you very much for your contribution ❤️

The GitLab Terraform Provider project has been moved to GitLab and
we welcome your contribution there 🎉

@github-actions github-actions bot closed this Nov 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation needs-rebase For PRs which need a rebase provider resource Adds or modifies a resource size/L tests
6 participants