Merge pull request #1937 from djrichar/MemberRoleIdForSAMLGroupLink

Issue: #1936 fix Missing MemberRoleId for group link creation
xanzy · May 10, 2024 · 6c765d2 · 6c765d2
2 parents aee1e19 + 3291483
commit 6c765d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/groups.go b/groups.go
@@ -881,6 +881,7 @@ func (s *GroupsService) GetGroupSAMLLink(gid interface{}, samlGroupName string,
 type AddGroupSAMLLinkOptions struct {
 	SAMLGroupName *string           `url:"saml_group_name,omitempty" json:"saml_group_name,omitempty"`
 	AccessLevel   *AccessLevelValue `url:"access_level,omitempty" json:"access_level,omitempty"`
+	MemberRoleID  *int              `url:"member_role_id,omitempty" json:"member_role_id,omitempty"`
 }
 
 // AddGroupSAMLLink creates a new group SAML link. Available only for users who

diff --git a/groups_test.go b/groups_test.go
@@ -569,6 +569,7 @@ func TestAddGroupSAMLLinkCustomRole(t *testing.T) {
 	opt := &AddGroupSAMLLinkOptions{
 		SAMLGroupName: Ptr("gitlab_group_example_developer"),
 		AccessLevel:   Ptr(DeveloperPermissions),
+		MemberRoleID:  Ptr(123),
 	}
 
 	link, _, err := client.Groups.AddGroupSAMLLink(1, opt)