Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Keep GH issue templates up to date. #8942

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented May 13, 2024

Update GH issue templates, removing EOL Classic and .NET 7.

@jpobst jpobst marked this pull request as ready for review May 15, 2024 17:52
@jpobst jpobst requested a review from jonpryor as a code owner May 15, 2024 17:52
Comment on lines +17 to +18
- net8.0-android
- net9.0-android
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these just say ".NET 8" and ".NET 9"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with this because the .NET version you install isn't necessarily the bits you are using. That is, if you install .NET 9 and target net8.0-android, you are actually using the .NET 8 bits but customers don't know that. I thought it might be more helpful for us to know what TF they are actually using.

That said, I don't have a strong opinion either way. 🤷

Comment on lines 57 to 58
description: Please copy and paste any (short!) relevant log output. Longer logs can be attached as .txt files. This is likely a [diagnostic MSBuild log](https://docs.microsoft.com/en-us/xamarin/android/troubleshooting/troubleshooting#diagnostic-msbuild-output) or attach a [MSBuild binlog](https://docs.microsoft.com/en-us/visualstudio/msbuild/obtaining-build-logs-with-msbuild?view=vs-2022#save-a-binary-log).
description: Please copy and paste any (short!) relevant log output. Longer logs can be attached as .txt files. This is likely a [diagnostic MSBuild log](https://docs.microsoft.com/en-us/xamarin/android/troubleshooting/troubleshooting#diagnostic-msbuild-output) or attach a [MSBuild binlog](https://aka.ms/binlog).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are docs.microsoft.com URLs, should those be learn.microsoft.com now?

I think we are also supposed to remove the /en-us/, so it will localize for other languages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct on both counts: use learn.microsoft.com, and remove /en-us from the URLs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines -28 to +29
placeholder: E.g. VS 2022 17.8.0, VSMac 17.6.7, .NET 8.0.100, etc.
placeholder: E.g. VS 2022 17.9.0, .NET 8.0.100, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ask for the VS Code version? Maybe just the version of the MAUI extension?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the intent here is to help us determine what version of our code they are using. Since VSCode doesn't ship our bits, I don't know if its version helps any. For VSCode users I suspect we would rather they provide the .NET version.

@jonpryor jonpryor merged commit f5fcd4d into main Jun 3, 2024
48 checks passed
@jonpryor jonpryor deleted the issue-templates branch June 3, 2024 19:01
grendello added a commit that referenced this pull request Jun 4, 2024
* main:
  [GitHub] Keep GH issue templates up to date. (#8942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants