[Microsoft.Android.Templates] Add icons to templates #8883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like (recently?) the Classic Xamarin templates got new icons that actually match the current VS look:
Can we find these icons and use them as they look much better than the one currently in this PR? |
|
I guess Classic Xamarin only has good icons for project templates, the item templates still use the very old icons that do not match current VS:
|
|
The Xamarin.Android template icons are here: |
Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1714750 Context: https://github.com/dotnet/maui/blob/8e4450cbc14932a6c74aeb8b7bfee9c94eca18b0/src/Templates/src/templates/maui-mobile/.template.config/ide.host.json#L3 The way to specify an icon for a `dotnet new` template is to specify an `icon` key within `.template.config/ide.host.json`.
Context: #8883 (comment) Opinion was that the icons for Classic Xamarin.Android within VS 17.9 were better than the icons added in this PR. Update the *project* templates to use the older icons. *Item* templates are unchanged, and use the new icon.
jonpryor
force-pushed
the
dev/jonp/jonp-add-project-icons
branch
from
8540841
to
914b788
Compare
jonathanpeppers
approved these changes
May 14, 2024
grendello
added a commit
that referenced
this pull request
May 16, 2024
* main: [Mono.Android] AndroidMessageHandler should follow HTTP-308 redirects (#8951) [Microsoft.Android.Templates] Add icons to templates (#8883) [native] Native call tracing infra + native build system overhaul (#8857) [build] fix code-flow from dotnet/installer, .NET 9.0.100-preview.5.24262.2 (#8949) [ci] Re-enable to push to dotnet9 feed (#8950) LEGO: Merge pull request 8952 [ci] Improve maestro artifact publishing (#8945)
grendello
added a commit
that referenced
this pull request
May 16, 2024
* main: [Mono.Android] AndroidMessageHandler should follow HTTP-308 redirects (#8951) [Microsoft.Android.Templates] Add icons to templates (#8883) [native] Native call tracing infra + native build system overhaul (#8857) [build] fix code-flow from dotnet/installer, .NET 9.0.100-preview.5.24262.2 (#8949) [ci] Re-enable to push to dotnet9 feed (#8950) LEGO: Merge pull request 8952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1714750
Context: https://github.com/dotnet/maui/blob/8e4450cbc14932a6c74aeb8b7bfee9c94eca18b0/src/Templates/src/templates/maui-mobile/.template.config/ide.host.json#L3
The way to specify an icon for a
dotnet newtemplate is to specify aniconkey within.template.config/ide.host.json.