Try a project with a space in Name #8468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Oct 27, 2023
It doesn't test that the "ProjectName" has spaces in it. Just the path to the project has special chars I think |
dellis1972
force-pushed
the
WI1852953
branch
3 times, most recently
from
27a58c3
to
190ffa9
Compare
dellis1972
force-pushed
the
WI1852953
branch
from
32e62eb
to
72240ef
Compare
dellis1972
force-pushed
the
WI1852953
branch
from
72240ef
to
c5c065f
Compare
grendello
approved these changes
Nov 29, 2023
| [TestCase ("Test Me")] | ||
| // testing characters as per https://www.compart.com/en/unicode/category/Zs | ||
| [TestCase ("TestUnicodeSpace0020\u0020Me")] | ||
| // TODO these break with AOT error on windows |
There was a problem hiding this comment.
Is there a way to make the tests run only on macOS and Linux?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have on occasion had reports of users using a space in their "Project Name". We already have a test which checks for spaces in the path, but not in the project name. This commit adds this test and fixes up a few area's where this caused a problem.
It should be noted that certain unicode based characters still cause issues with the .net Aot compiler. These unit test cases have been commented out for now.