Always call super on initialize

rubocop/ruby-style-guide#809
x-govuk · Jan 13, 2021 · 315e31c · 315e31c
1 parent 055bb94
commit 315e31c
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/lib/govuk_design_system_formbuilder/containers/character_count.rb b/lib/govuk_design_system_formbuilder/containers/character_count.rb
@@ -2,7 +2,7 @@ module GOVUKDesignSystemFormBuilder
   module Containers
     class CharacterCount < Base
       def initialize(builder, max_words:, max_chars:, threshold:)
-        @builder = builder
+        super(builder, nil, nil)
 
         fail ArgumentError, 'limit can be words or chars' if max_words && max_chars
 

diff --git a/lib/govuk_design_system_formbuilder/containers/check_boxes.rb b/lib/govuk_design_system_formbuilder/containers/check_boxes.rb
@@ -2,7 +2,8 @@ module GOVUKDesignSystemFormBuilder
   module Containers
     class CheckBoxes < Base
       def initialize(builder, small:, classes: nil)
-        @builder = builder
+        super(builder, nil, nil)
+
         @small   = small
         @classes = classes
       end

diff --git a/lib/govuk_design_system_formbuilder/containers/radios.rb b/lib/govuk_design_system_formbuilder/containers/radios.rb
@@ -4,7 +4,8 @@ class Radios < Base
       include Traits::Hint
 
       def initialize(builder, inline:, small:, classes:)
-        @builder = builder
+        super(builder, nil, nil)
+
         @inline  = inline
         @small   = small
         @classes = classes

diff --git a/lib/govuk_design_system_formbuilder/elements/error_summary.rb b/lib/govuk_design_system_formbuilder/elements/error_summary.rb
@@ -4,8 +4,8 @@ class ErrorSummary < Base
       include Traits::Error
 
       def initialize(builder, object_name, title, link_base_errors_to:)
-        @builder             = builder
-        @object_name         = object_name
+        super(builder, object_name, nil)
+
         @title               = title
         @link_base_errors_to = link_base_errors_to
       end

diff --git a/lib/govuk_design_system_formbuilder/elements/null.rb b/lib/govuk_design_system_formbuilder/elements/null.rb
@@ -1,7 +1,9 @@
 module GOVUKDesignSystemFormBuilder
   module Elements
     class Null < Base
-      def initialize; end
+      def initialize
+        super(nil, nil, nil)
+      end
 
       def html
         nil

diff --git a/lib/govuk_design_system_formbuilder/elements/submit.rb b/lib/govuk_design_system_formbuilder/elements/submit.rb
@@ -4,9 +4,10 @@ class Submit < Base
       using PrefixableArray
 
       def initialize(builder, text, warning:, secondary:, classes:, prevent_double_click:, validate:, disabled:, &block)
+        super(builder, nil, nil)
+
         fail ArgumentError, 'buttons can be warning or secondary' if warning && secondary
 
-        @builder              = builder
         @text                 = text
         @prevent_double_click = prevent_double_click
         @warning              = warning