Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-surface: Avoid recursive update of surface cache #2261

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

xerial
Copy link
Member

@xerial xerial commented Jun 21, 2022

An alternative approach for #2260 as concurrent creation of the same Surface type should not be a big issue.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #2261 (fc1e0cb) into master (1329010) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
- Coverage   82.60%   82.58%   -0.02%     
==========================================
  Files         315      315              
  Lines       12440    12440              
  Branches      797      792       -5     
==========================================
- Hits        10276    10274       -2     
- Misses       2164     2166       +2     
Impacted Files Coverage Δ
...c/main/scala/wvlet/airframe/surface/Surfaces.scala 85.71% <0.00%> (-2.68%) ⬇️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 94.73% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40500b3...fc1e0cb. Read the comment docs.

@xerial xerial merged commit 3491827 into master Jun 21, 2022
@xerial xerial deleted the surface-cache branch June 21, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant