chore: add formatting and ci tools for go #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
devsergiy
reviewed
Oct 7, 2022
devsergiy
reviewed
Oct 7, 2022
- Install golangci-lint and gci via check-setup - Add Makefile targets for golang-ci and golang-ci-fix. The former runs the same checks as CI while the latter tries to fix any errors (e.g. like incorrect formatting, not everything is automatically fixable)
fiam
force-pushed
the
alberto/go-ci-format-tools
branch
from
1d3ce85
to
ca80fe1
Compare
devsergiy
approved these changes
Oct 7, 2022
StarpTech
requested changes
Oct 7, 2022
Add also a Makefile target to run it
|
@StarpTech Thanks for the review! Could you please override the check and merge? This is hitting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test