Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option name in README.md. #68

Merged
merged 1 commit into from Oct 11, 2022
Merged

Conversation

ezio-melotti
Copy link
Contributor

Just a minor mistake in the documentation -- the path of the image defined in ogp_image is relative to ogp_site_url, not ogp_site_name:

else: # ogp_image is set
# ogp_image is defined as being relative to the site root.
# This workaround is to keep that functionality from breaking.
root = config["ogp_site_url"]
image_url = urljoin(root, image_url_parsed.path)
tags["og:image"] = image_url

@Daltz333 Daltz333 merged commit b3c9eb8 into wpilibsuite:main Oct 11, 2022
@ezio-melotti ezio-melotti deleted the patch-1 branch October 11, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants