Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow dirhtml builder without
ogp_site_url
- Yes, the readme says that ogp_site_url is very important. And indeed, reports online say that OGP doesn't work with relative URLs. Although at least one place says it does... - Yet, I got confused when I could build it with html (it left everything relative), but not with dirhtml (obscure extension error it took me a while to figure out). (And it only fails on the page named `/index`. - Set the default ogp_site_url to "" by default, instead of None, to make relative by default (previous behavior) instead of raising an exception. - Even if this isn't perfect, it helps a bit with "make this extension do something useful, even if not perfect, if it's installed but not configured". - So overall, even though this isn't a perfect change, and could be considered technically incorrect, I think it's less confusing and makes things more consistent for a possibly better solution later.
- Loading branch information