remove charset=UTF-8 #3946
Merged
remove charset=UTF-8 #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafa-hisham
added
the
type: bug
iCaspar
approved these changes
May 24, 2021
crystinutzaa
pushed a commit
that referenced
this pull request
Jun 3, 2021
* Fixes #3478 Enable installation through composer v2 (PR #3928) * update woocommerce from wpackagist * update woocommerce paths * use composer v2 in GH actions * Re-add change to remove disable preload fonts when CPCSS is enabled (PR #3927) * remove callback disabling preload fonts * remove associated tests * Stop preload while prewarmup is running (PR #3925) * start automatic preload just after prewarmup finishes its work * Block manual preload till finishing prewarmup * check the RUCSS option enabled along with allow_optimization * fix old tests * [WIP] stop preload with enabling RUCSS * migrate maybe_cancel_preload to RUCSS admin subscriber * fix old tests * remove charset=UTF-8 (PR #3946) * remove charset=UTF-8 * remove charset=UTF-8 from delete * Add unit tests code coverage (PR #3922) * add code coverage command * update incorrect annotations * add cove coverage action * enable xdebug for coverage * Fix failing tests related to adding prewarmup functionality (PR #3949) * Guard our code by checking if table is exists before updating prewarmup * With switch_theme only start scanner when RUCSS is enabled * change trigger event to push * Fixes RUCSS tests: update time to prevent tests failures (PR #3973) * Fixes #3600 add wpstage to staging servers list (PR #3948) * add wpstage to staging servers * remove image optimization when WP_ROCKET_WHITE_LABEL_ACCOUNT (PR #3956) * remove image optimization menu when WP_ROCKET_WHITE_LABEL_ACCOUNT is used * Add Hubspot iframe inline JS exclusion from combine JS (PR #3943) * Fixes #3945 Display warning when WP Meteor is enabled with WP Rocket delay JS (PR #3974) * add new add_plugins_incompatibility() method * add options class to settings class dependencies * updating existing tests * add add_plugins_incompatibility() test file * add unit & integration tests * Fixes #3924 Remove unnecessary more info link in RUCSS pre-warmup copy (PR #3981) * Compatibility with Impreza theme (PR #3972) * Add Impreza inline script pattern to exclude * Add Fixtures Co-authored-by: Rémy Perona <remperona@gmail.com> * Update delay JS script (PR #3971) * update delay JS script * update delay JS fixture * add touchchancel and touchforcechange events * update fixture with new events * Fixes #2876 Remove beacon button when white label is enabled (PR #3965) * remove beacon btn if white label is true * remove ask support button too * Add additional delay JS exclusions (PR #3975) * Add additional exclusions from delay JS * Update fixtures * update plugin version to 3.9.0.1 * update operator in version_compare Co-authored-by: Ahmed Saed <eng.ahmeds3ed@gmail.com> Co-authored-by: mostafa-hisham <mostafa.hisham.mahmoud@gmail.com> Co-authored-by: Natalia Drause <60236665+NataliaDrause@users.noreply.github.com> Co-authored-by: Jonathan Buttigieg <jonathan@wp-media.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the ;charset=UTF-8 from our js file
Fixes #3645
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
No
How Has This Been Tested?
I can't reproduce the issue locally (even on our test site) using chrome 90,89,68,60
Checklist: