Node/CCQ: Solana library not honoring min context slot #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
requested review from
evan-gray,
panoel and
kev1n-peters
as code owners
evan-gray
approved these changes
Jan 25, 2024
panoel
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solana library we are using does not honor the
MinConextSlotoption on theGetMultipleAccountsWithOptscall like it does on theGetAccountWithOptscall.An issue has been opened against the library. In the meantime, the troublesome function has been copied into the watcher and tweaked to support the parameter.
Note to reviewers: The function is basically the same as the one in the library with this addition.