Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): ember-auto-import@2 compatibility #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buschtoens
Copy link

Makes this addon compatible with ember-auto-import@2 host apps.

Closes #25.

This is not the ideal solution, but the most trivial one.

As this addon is considered dormant and its features are set to be upstreamed into ember-qunit, I don't expect the owner @workmanw to cut a new release. Instead affected users may use patch-package to apply this fix locally.

@ef4
Copy link

ef4 commented Jan 31, 2022

The other thing I'd recommend is dropping this auto-registration entirely and telling users to do this import themselves, from their test-setup.js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants