Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP async support #10

Closed
wants to merge 1 commit into from
Closed

Conversation

stefanpenner
Copy link
Collaborator

@stefanpenner stefanpenner commented Apr 28, 2017

this is still WIP.

Plan:

add async support to the various helpers, so that we can more easily use them in ember-data.

for example:

return assert.expectAssertion(() => {
  return store.somethingThatEventuallyAsserts();
});
  • complete functionality
  • ensure test have been added.

@stefanpenner
Copy link
Collaborator Author

I am upstreaming these assertions into ember-qunit. The upstreamed variants include async by default where appropriate.

related ember-test-helpers PRs

When all this lands, my plan is to deprecate this library entirely in-favor of it's assertions simply being officially supported: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant