Add south africa holiday 2022/12/27 #729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @rneilkennedy |
|
If we could get this in before the 27th that would be great 🙏 |
brunobord
requested changes
Dec 30, 2022
There was a problem hiding this comment.
sorry about this very very very late response, but I've (again) neglected this project for too long.
I'd be glad to add your contribution to the project, but I think it misses several things. At least:
- a few tests in the test_africa.py file to validate this new holiday in the year 2022,
- a changelog entry describing your change
Also, you'll need to rebase from the latest master, in order to validate your contribution against Python 3.10 & Python 3.11. The latest code also drops compatibility with Python 3.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #
https://www.gov.za/about-sa/public-holidays