Anbima calendar #726
Anbima calendar #726
Conversation
workalendar/tests/test_brazil.py
Outdated
| @@ -1009,3 +1009,71 @@ def test_no_duplicate(self): | |||
| def test_all_are_brazilian_classes(self): | |||
| for key, value in IBGE_TUPLE: | |||
| self.assertTrue(issubclass(value, Brazil)) | |||
|
|
|||
| @pytest.mark.anbima_test | |||
workalendar/tests/test_america.py
Outdated
| @@ -1,7 +1,10 @@ | |||
| from datetime import date | |||
|
|
|||
| from ..america import (Argentina, Barbados, Chile, Colombia, Mexico, Panama, | |||
| Paraguay) | |||
| Paraguay,) | |||
There was a problem hiding this comment.
what's that change here? Brazil has its own test module...
There was a problem hiding this comment.
Actually i see this before, that brazil has it own module. I started to code on america, but i cut all to brazil module. This edit in truth dont change anything.
There was a problem hiding this comment.
@brunobord, i think that i solve the problems can you check again ? Thanks for instruct me, this is my first pr
Merge branch 'master' into anbima_calendar
|
I think that is nice now, i need do something more? |
There was a problem hiding this comment.
as you may see, you've got several errors in your code.
I'd recommend you to try to solve them by running the tests locally first, and fix them step by step. Your main problem apparently comes from the line 633 in the workalendar/america/brazil.py file, in which you're trying to use the workalendar.america.Brazil class, while the root module of this namespace (namely workalendar has not been defined or imported).
I think you'd rather put just Brazil here, instead. This class is defined in this very file, so it's already loaded in the current namespace.
This change should at least remove several errors. There might be others.
If you need help on how to fix your PR, please don't hesitate to ask.
Changelog.md
Outdated
| @@ -4,6 +4,10 @@ | |||
|
|
|||
| Nothing here yet. | |||
|
|
|||
| ## v17.1.0 (2023-01-02) | |||
There was a problem hiding this comment.
please, remove this "release number" here, you'd rather add the changelog entry to the current (master) section.
FYI, it's in the Github PR template, as well as in the "How to Contribute" documentation: https://github.com/workalendar/workalendar/blob/master/docs/contributing.md#the-final-steps
davimmilhome
force-pushed
the
anbima_calendar
branch
from
74c994b
to
ced7151
Compare
|
Yeah man, sory for the preview code, i was learning. I corect the tests now, maybe fine now. About changelog i rly dont know what mean the # with three numbers. Hope you're doing well guys and Bruno! |
|
I think that im messing up with some config in my setup that generate so many unecessary files from commit, maybe a pycharm feature, i have to search about it, but at time, i exclude all this files manually |
refs #
For information, read and make sure you're okay with the Contributing guidelines.
workalendar.registry_tools.iso_registerdecorator to register your new calendar using ISO codes (optional).<country>by@pseudo(#)". Note Please do NOT change the version number here. It's the project maintainers' duty.