Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add holy_monday for chilean calendar #725

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add holy_monday for chilean calendar #725

wants to merge 6 commits into from

Conversation

ajcobo
Copy link
Contributor

@ajcobo ajcobo commented Oct 11, 2022

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

brunobord
brunobord requested changes Dec 30, 2022
View reviewed changes
Copy link
Member

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please:

  • rebase from latest master (if you have trouble with rebasing, please tell me, and I'll take your contribution over)
  • fix your eventual flake8 error issues

@ajcobo ajcobo requested a review from brunobord January 3, 2023 21:44
@ajcobo
Copy link
Contributor Author

ajcobo commented May 23, 2023

Rebased and checked

@ajcobo
Copy link
Contributor Author

ajcobo commented Jan 12, 2024

Please review and merge 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobord brunobord Awaiting requested review from brunobord

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajcobo @brunobord