➕ Added calender for India. #724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bserved across India are added. Regional and variable holidays based on Hindu Calender to be added in future
brunobord
requested changes
Dec 30, 2022
There was a problem hiding this comment.
only a slight issue with you change in the .gitignore file.
also, you may want to rebase from latest master, which has dropped compatibility with Python 3.6, and has added compatibility with Python 3.10 + 3.11.
If you need any help about rebasing, please tell me, I'll take your PR over.
Sorry for the very long delay, I've (again) neglected this project for too long.
| @@ -11,3 +11,4 @@ pyproject.toml | |||
| .cache/ | |||
| .pytest-cache/ | |||
| .pytest_cache/ | |||
| .idea/ | |||
There was a problem hiding this comment.
this has nothing to do with this contribution.
could you please remove this change?
|
Is this an active PR? I can consider the changes and raise the same PR. |
|
Hey @rehanguha happy for you to take over this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only major holidays which are observed across India are added. Regional and variable holidays based on Hindu Calender to be added in future
refs #
For information, read and make sure you're okay with the Contributing guidelines.
workalendar.registry_tools.iso_registerdecorator to register your new calendar using ISO codes (optional).<country>by@pseudo(#)". Note Please do NOT change the version number here. It's the project maintainers' duty.