Standardization and translation of Brazilian holidays

[luismalta]

This PR is intended to:

• Translate Brazilian holidays
• Standardize the names of Brazilian holidays

[augustodinizl]

Ok...

[augustodinizl]

It's missing 11/20 - "Dia de Zumpi e Consciência Negra"

[luismalta]

"Dia da Consciência Negra" is already in this calendar, it comes from the calendar of the state of São Paulo.

[brunobord]

Hello peeps, nice to see you back on workalendar. :o)

This PR is a dilemma for me (not a serious one, but still)... Using the pt-BR labels for Brazilian holidays is a bold move, because it may have consequences. Let me put this in a broader context:

1. The usual "best practices" about i18n is: first of all put all your strings in English, as a pivot language and then you can activate a translation effort from English to every other language.
2. It has been roughly the norm or standard in workalendar since day 1, with a few exceptions for religious holidays that wouldn't make any sense to be translated, for example. (e.g. Deepavali or Diwali, which translates as "row or series of lights" ; putting it into English would be silly, wouldn't it?)
3. I know that the i18n and translation enablement is a long-due feature request. This task would be tedious, and would require a lot of effort now that we have more than 200 calendars. I guess that it would mean to:
   a. open a project on crowdin or transifex
   b. start adding translatable strings through several waves of gettext-ization
   c. ask for volounteers to start translating
   d. have a precise process for retrieving translated strings, etc. Nothing completely impossible, but you'd probably won't be able to improvise it in a day.

Looking at our "roadmap", the Internationalization of workalendar was one of my goals for 2020, in collaboration with our (PeopleDoc's) content and i18n managers.

Now onto your pull-request. Merging it would have consequences:

• the calendar holiday labels would be a mix between English and Portuguese (BR) terms. Not that it's a big issue: it already happens on many calendars, including the Brazilian calendars. The only one left in English are "New Year" and "Christmas". Not a big deal, of course.
• The good point for you is that you can use the holiday labels directly, just "translating" the "New Year" & "Christmas" labels on the fly ; I assume that it's within anyone's capabilities.
• The hard point comes here: if at some point we start to make all labels translatable, you'll have to somehow revert your pull-request to get back to "mostly English" (or any pivot source string).

Unfortunately, I can't tell you how long it will take until we start the i18n work. And of course, depending on the path we'll take, you'll probably have to make modifications on how you're using the library.

I feel like these Brazilian calendars are now a bit more yours than mine, so it's probably going to be your call: either you take the chance to have pt-BR labels now, or wait for us to be ready to internationalize.

Regards.

[mileo]

Hello when @luismalta asked me to review the pr I thought of this deficiency....

We can contribute to the translation, but only next year. =(

I think of the following roadmap:

• Create a blank file export / sync tool for new languages;
• Use some online translation tool that synchronizes automatically;
• Keep all terms in English;

It will not be a simple task and it will really take a while, but there are certainly many good examples on the internet.

Best regards

[Natim]

Create a blank file export / sync tool for new languages;

I started #441 for this purpose.