Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing setInterval not cleared on microphone state #3213

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fixing setInterval not cleared on microphone state #3213

merged 1 commit into from
Apr 26, 2023

Commits on Apr 26, 2023

  1. Fixing setInterval not cleared on microphone state 

    Because of a bug in Svelte (see sveltejs/svelte#5268), the onDestroy callback of sub-components are not called if one of the parent components has a transition.

This in turn caused stores to not be unsubscribed, and ultimately, a "setInterval" to read the microphone audio level not to be cleared.

We fix this by removing any Svelte based transitions/animations.
    @moufmouf
    moufmouf committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    48d4c9d View commit details
    Browse the repository at this point in the history