Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery Block] Update test suite to reflect the fact "link to" settings are no longer broken #116

Merged
merged 1 commit into from
May 10, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented May 10, 2022

The Gallery test suite previously had the following note above the steps to test the block's "link to" settings:

**KNOWN ISSUE**: This test case is not currently working. Please skip. [See here](https://github.com/WordPress/gutenberg/issues/23576) for more details.

This issue was fixed in WordPress/gutenberg#40947, so the settings should be working as expected again. As such, this PR removes the note.

@SiobhyB SiobhyB changed the title Reflect fact "link to" is no longer broken [Gallery Block] Update test suite to reflect the fact "link to" settings are no longer broken May 10, 2022
@SiobhyB SiobhyB marked this pull request as ready for review May 10, 2022 14:34
@SiobhyB SiobhyB requested review from fluiddot and jhnstn May 10, 2022 14:34
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@SiobhyB SiobhyB merged commit c39fb0e into trunk May 10, 2022
@SiobhyB SiobhyB deleted the update/gallery-known-link-to-issue branch May 10, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants