Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update second Gutenberg Mobile package reference in package-lock.json #6312

Merged
merged 2 commits into from Oct 23, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Oct 23, 2023

After running npm install against trunk, the second reference to Gutenberg Mobile's package version in package-lock.json was updated from 1.105.0 to 1.106.0.

I believe the structure of package-lock.json changed following the latest node/npm upgrades in WordPress/gutenberg#53426, which may be why we don't currently account for this second reference as part of our release process.

To test:

  • With this branch checked out, run npm install to confirm no changes are suggested.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @SiobhyB !

@SiobhyB SiobhyB merged commit 1f5031f into trunk Oct 23, 2023
15 of 17 checks passed
@SiobhyB SiobhyB deleted the release/package-lock-version-update branch October 23, 2023 22:16
@derekblank
Copy link
Member

@SiobhyB I believe this should be included in the upcoming 1.107.0 milestone that will be cut later this week, but just wanted to double check with you first.

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Oct 24, 2023

👋 @derekblank, yes, we'd need to make sure the value is updated to 1.107.0 for the next release (and to reflect the release version for all future releases, too). I think it'd be necessary to run npm install somewhere in the release script to ensure it gets updated.

@derekblank derekblank added this to the 1.107.0 (23.6) milestone Oct 24, 2023
@derekblank
Copy link
Member

Thanks for clarifying -- I've added it to the 1.107.0 milestone. And good point about running npm install during the release as well. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants