Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum node and npm versions #6050

Merged
merged 4 commits into from Aug 9, 2023
Merged

Update minimum node and npm versions #6050

merged 4 commits into from Aug 9, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 9, 2023

Following the changes introduced in WordPress/gutenberg#53426. We update the node and npm versions to use:

  • node 16
  • npm 8

To test:

  • Observe that all CI jobs pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added this to the 1.102.0 (23.1) milestone Aug 9, 2023
@fluiddot fluiddot self-assigned this Aug 9, 2023
@fluiddot fluiddot marked this pull request as ready for review August 9, 2023 10:59
@SiobhyB SiobhyB self-requested a review August 9, 2023 11:08
SiobhyB
SiobhyB approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes look good, as well as the fact I'm able to build the demo apps with them applied. Thank you for updating this @fluiddot 🙇‍♀️

@fluiddot fluiddot merged commit c2378be into trunk Aug 9, 2023
16 checks passed
@fluiddot fluiddot deleted the update/minimal-node-and-npm-upgrade branch August 9, 2023 11:42
@fluiddot fluiddot mentioned this pull request Aug 9, 2023
Merged
2 tasks
@noahtallen
Copy link

By the way, I'd highly recommend running npm dedupe to reduce the number of changes in the package-lock file!

@fluiddot
Copy link
Contributor Author

By the way, I'd highly recommend running npm dedupe to reduce the number of changes in the package-lock file!

Oh, I didn't know about that command, thanks for the recommendation Noah 🙇 ! I'll create another PR to apply this suggestion.

@fluiddot fluiddot mentioned this pull request Aug 10, 2023
Merged
2 tasks
@fluiddot
Copy link
Contributor Author

Oh, I didn't know about that command, thanks for the recommendation Noah 🙇 ! I'll create another PR to apply this suggestion.

Done here: #6054.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

Assignees

@fluiddot fluiddot

Labels
Tooling
Projects
None yet
Milestone
1.102.0 (23.1)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fluiddot @noahtallen @SiobhyB