Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.81.1 #5119

Merged
merged 17 commits into from Aug 26, 2022
Merged

Release 1.81.1 #5119

merged 17 commits into from Aug 26, 2022

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Aug 24, 2022

Release for Gutenberg Mobile 1.81.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 馃帀

Changes

List block v2: Fix text color inconsistencies with list items

Use default placeholder text color for native List Item

Add BlockListCompact

Disable FastImage on Android

Fix dynamic React Native version

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@geriux geriux marked this pull request as ready for review August 25, 2022 16:14
@derekblank
Copy link
Member

Writing Flow checklist (iOS) 馃煝

Build: pr19238-854c1ae
Device: iPhone SE

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@derekblank
Copy link
Member

derekblank commented Aug 26, 2022

New Changes (iOS) 馃煝

Build: pr19238-854c1ae
Device: iPhone SE

  • List Block v2: Text color inconsistencies in dark mode #43146
  • List Block v2: Prefilled word "list" (text placeholder) isn't greyed-out #5098
  • Editor Crash when saving post with large/complex List Block V2 #5097
  • Disable FastImage on Android #43149 (Technically N/A on iOS, but tested successfully anyways.)

@geriux
Copy link
Member

geriux commented Aug 26, 2022

馃煝 Writing Flow checklist (Android)

Build: pr17090-56c9c96
Device: Redmi Note 8T (OS 11)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃帄 !

---
* [*] List block v2: Fix text color inconsistencies with list items [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5096]
* [*] Use default placeholder text color for native List Item [https://github.com/WordPress/gutenberg/pull/43353]
* [*] Add BlockListCompact [https://github.com/WordPress/gutenberg/pull/43431]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I noticed that this entry in the React Native editor's changelog has two ** (reference).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the release tag was already created, I'd update this in a different PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! 馃槄 I'll update it once I start merging back to trunk 馃憤

* [*] Use default placeholder text color for native List Item [https://github.com/WordPress/gutenberg/pull/43353]
* [*] Add BlockListCompact [https://github.com/WordPress/gutenberg/pull/43431]
* [*] Fix dynamic React Native version [https://github.com/WordPress/gutenberg/pull/43058]
* [*] Disable FastImage on Android [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5102]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I noticed that this entry in the React Native editor's changelog has two ** (reference).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the release tag was already created, I'd update this in a different PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it, thanks for catching that!

@geriux
Copy link
Member

geriux commented Aug 26, 2022

Additional package-lock.json changes are due to updates in WordPress/gutenberg#43511 since we are bringing the latest trunk from Gutenberg.

@geriux
Copy link
Member

geriux commented Aug 26, 2022

Waiting to merge WordPress/gutenberg#43612 so CI checks can pass.

@@ -106,14 +106,13 @@ describe( 'Gutenberg Mobile initialization', () => {
{ locale: defaultLocale, capabilities },
{ component: EditorComponent }
);
const blockList = screen.getByTestId( 'block-list-wrapper' );
// Inner blocks create BlockLists so let's take into account selecting the main one
const blockList = screen.getAllByTestId( 'block-list-wrapper' )[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were already introduced in the Gutenberg repo.

@dcalhoun dcalhoun self-assigned this Aug 26, 2022
@dcalhoun dcalhoun merged commit d8c86e9 into trunk Aug 26, 2022
@dcalhoun dcalhoun deleted the release/1.81.1 branch August 26, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants