Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dagger to 2.41 #16101

Merged
merged 2 commits into from Mar 15, 2022
Merged

Update Dagger to 2.41 #16101

merged 2 commits into from Mar 15, 2022

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Mar 14, 2022

This PR updates Dagger to 2.41.

Except for the bug fixes and Hilt (*) related changes, this update has the following changes that is worth noting:

  • 2.30
    • experimentalDaggerErrorMessages by default.
  • 2.31
    • Assisted Injection support.
  • 2.36
    • Compile time set binding validation.
  • 2.38
    • Google Maven repository for KSP artifacts.
  • 2.41
    • A long-standing bug is now fixed.
    • Slight change in string format of bindings.
    • Improved error messages for unresolvable deferred types.
    • Support for jakarta.inject.

Non of the above and any other change are breaking building and/or running the app.

(*) Since WPAndroid hasn't migrated to Hilt just yet (see here), any such related changes are excluded from the above notes.

To test:

  • Smoke test the app.

Regression Notes

  1. Potential unintended areas of impact

N/A

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

N/A

  1. What automated tests I added (or what prevented me from doing so)

N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParaskP7 ParaskP7 added this to the 19.5 milestone Mar 14, 2022
@ParaskP7 ParaskP7 self-assigned this Mar 14, 2022
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@ParaskP7 ParaskP7 requested a review from a team March 14, 2022 16:18
@ParaskP7 ParaskP7 marked this pull request as ready for review March 14, 2022 16:19
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating Dagger. It was important for hilt migration.
Smoke tested and couldn't find any problem. 👍🏻

@irfano irfano merged commit f668678 into trunk Mar 15, 2022
@irfano irfano deleted the update/dagger-to-2.40.5 branch March 15, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants