Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow delete method request to send data #986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow delete method request to send data #986

wants to merge 1 commit into from

Conversation

BenjaminMINK
Copy link

@BenjaminMINK BenjaminMINK commented Apr 18, 2024 •
edited

Hello,

I think the delete method should be allowed to send data on request method

@wopian wopian self-requested a review April 20, 2024 21:51
wopian
wopian requested changes Apr 20, 2024
View reviewed changes
Copy link
Owner

@wopian wopian left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that sends a DELETE request with a body in the delete.spec.js file, so that this change is covered? You should be able to utilise one of the existing tests in POST or PATCH.

@BenjaminMINK
Copy link
Author

Can you add a test that sends a DELETE request with a body in the delete.spec.js file, so that this change is covered? You should be able to utilise one of the existing tests in POST or PATCH.

Okay, I'll add it

@BenjaminMINK
Copy link
Author

Hello,

It seems we need more than just adding a single test: with the proposed modification, many tests fails because many are related to the request method which is not handling well different cases, especially in the isValid method called from serialise that we need to also handle the DELETE that can be either empty or filled...

@wopian
Copy link
Owner

wopian commented May 12, 2024

I'll take a look into that in the coming week 👍

@wopian wopian self-assigned this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wopian wopian wopian requested changes

Assignees

@wopian wopian

Labels
enhancement in progress kitsu kitsu-core test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenjaminMINK @wopian