WIP: kitsu-core typescript implementations & JSON:API v1.1 type definitions #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedep
force-pushed
the
refactor/typescript
branch
from
fc8b39a
to
e26f850
Compare
wopian
requested changes
Nov 12, 2023
|
|
||
| if (output.attributes === data.attributes) delete output.attributes | ||
| function _deattribute(data: ResourceObject): DeattributedResourceObject { |
There was a problem hiding this comment.
This could be named deattributeObject
|
Thanks for taking this up! Overall it is looking very good so far! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently work in progress, but im opening the PR now to let @wopian peek at my progress.
I'm aware i may not be refactoring in-line with your visions, and am very open to critique and changes to fit the project coding-style.
Progress
camel(replaced bycase-anythingdep)kebab(replaced bycase-anythingdep)snake(replaced bycase-anythingdep)