Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependency react-icons to ~3.0.0 #123

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 31, 2018

This Pull Request updates dependency react-icons from ~2.2.7 to ~3.0.0

Note: This PR was created on a configured schedule ("before 2am" in timezone Europe/London) and will not receive updates outside those times.


Release Notes

v3.0.1

Compare Source


v3.0.0

Compare Source

Detail

  • support esmodules & change import style
  • global icon configure with context API
  • supports webpack optimization (speed up for build)
  • typescript native support
  • use gitsubmodules (easier update)
  • use yarn (easily to test by managing all related package in yarn workspace)
  • new icon set
    • feathericons
  • upgrade icon
    • fontawesome5
  • configure travis ci & deploy preview site to netlify
new import / configure style
import React from "react";

import { IconContext } from "react-icons";
import { FaFolder } from "react-icons/lib/fa";
import { MdAccessibility } from "react-icons/lib/md";

funciton App () {
return (
<IconContext.Provider value={{ color: "#&#8203;333" }}>
<div>
<MdAccessibility />
<FaFolder />
</div>
</IconContext.Provider>
);
}

build speed/size improvement!

Use one icon from each of fa and md.
SIZE: -84% BUILD TIME: -40%

before:

File sizes after gzip:

244.25 KB build\static\js\main.2f2e05e7.js
299 B build\static\css\main.c17080f1.css
Done in 19.83s.

after:

File sizes after gzip:

38.75 KB build\static\js\main.cc198299.js
299 B build\static\css\main.c17080f1.css

Done in 11.79s.

Migrate from version 2 -> 3

see: https://github.com/react-icons/react-icons#migrate-from-version-2---3

PR


This PR has been generated by Renovate Bot.

@wopian
Copy link
Owner

wopian commented Jul 31, 2018

Deploy preview for trends failed.

Built with commit 54e9386

https://app.netlify.com/sites/trends/deploys/5b61db4b73f2cf65a746f1ac

@renovate renovate bot force-pushed the renovate/react-icons-3.x branch from 0c25a01 to fbf450c Compare August 1, 2018 03:29
@renovate renovate bot force-pushed the renovate/react-icons-3.x branch from fbf450c to 54e9386 Compare August 1, 2018 16:09
@wopian
Copy link
Owner

wopian commented Aug 1, 2018

Blocked by react-icons/react-icons#154

@wopian wopian closed this Aug 1, 2018
@wopian wopian deleted the renovate/react-icons-3.x branch August 1, 2018 16:21
@renovate
Copy link
Contributor Author

renovate bot commented Aug 1, 2018

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 3.x releases. However, if you upgrade to 3.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants