Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pinned wp/element to 4.8.0 until we sort out esm dependencies #34349

Merged
merged 1 commit into from Aug 17, 2022

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Aug 17, 2022

All Submissions:

Changes proposed in this Pull Request:

Due to some upstream changes including a package that uses ESM, jest needs to transform such files before it can be run. Unfortunately at this point in time it is quite complicated and we will require more time to properly implement a fix.

More context at: p1660624973259689-slack-C03CPM3UXDJ

At this point in time we will just pin the @wordpress/element package at 4.8.0 across the entire repo, by using pnpm.overrides, so that we can still rely on unit tests.

How to test the changes in this Pull Request:

Purely a dev env change; Jest tests should pass both in CI and locally

  1. Try commands such as git clean -fdx && pnpm i && pnpm run build && cd ./plugins/woocommerce-admin && pnpm run test
  2. And also attempt to run tests within the packages themselves

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@rjchow rjchow marked this pull request as ready for review August 17, 2022 02:56
@rjchow rjchow requested a review from a team August 17, 2022 02:56
@rjchow rjchow added the focus: monorepo infrastructure Issues and PRs related to monorepo tooling. label Aug 17, 2022
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Tested well locally and looks good! 👍

@rjchow rjchow merged commit a6d656f into trunk Aug 17, 2022
@rjchow rjchow deleted the fix/pin-wp-elements-4-8-0 branch August 17, 2022 04:09
@louwie17 louwie17 mentioned this pull request Aug 17, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants