Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jest configuration changes to allow is-plain-obj esm #34334

Closed
wants to merge 1 commit into from

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Aug 16, 2022

All Submissions:

Changes proposed in this Pull Request:

Due to some upstream changes including a package that uses ESM, jest needs to transform such files before it can be run.

How to test the changes in this Pull Request:

Purely a dev env change; Jest tests should pass both in CI and locally

  1. Try commands such as git clean -fdx && pnpm i && pnpm run build && cd ./plugins/woocommerce-admin && pnpm run test
  2. And also attempt to run tests within the packages themselves

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added package: @woocommerce/components issues related to @woocommerce/components package: @woocommerce/csv-export issues related to @woocommerce/csv-export package: @woocommerce/currency issues related to @woocommerce/currency package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score package: @woocommerce/data issues related to @woocommerce/data package: @woocommerce/date issues related to @woocommerce/date package: @woocommerce/experimental issues related to @woocommerce/experimental package: @woocommerce/explat issues related to @woocommerce/explat package: @woocommerce/navigation issues related to @woocommerce/navigation package: @woocommerce/number issues related to @woocommerce/number labels Aug 16, 2022
@rjchow rjchow force-pushed the fix/is-plain-obj-esm-import branch from 358b13d to 83d6e01 Compare August 16, 2022 08:07
@rjchow rjchow force-pushed the fix/is-plain-obj-esm-import branch from 83d6e01 to e2d4a97 Compare August 17, 2022 01:31
@rjchow rjchow closed this Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: @woocommerce/components issues related to @woocommerce/components package: @woocommerce/csv-export issues related to @woocommerce/csv-export package: @woocommerce/currency issues related to @woocommerce/currency package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score package: @woocommerce/data issues related to @woocommerce/data package: @woocommerce/date issues related to @woocommerce/date package: @woocommerce/experimental issues related to @woocommerce/experimental package: @woocommerce/explat issues related to @woocommerce/explat package: @woocommerce/navigation issues related to @woocommerce/navigation package: @woocommerce/number issues related to @woocommerce/number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant