Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node.js 18 and bump all NPM dev dependencies #345

Merged
merged 3 commits into from Jan 4, 2024

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Dec 29, 2023

Changes proposed in this Pull Request:

Closes #281

  • Upgrade to use Node.js v18.
  • Bump all dev dependencies to solve all vulnerabilities.
    • This reduces the number of npm vulnerabilities from 34 to 0. 🎉
  • Fix JS linting errors.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Detailed test instructions:

  1. Set Node.js to v18.
  2. Run npm install to see if it can finish without errors.
  3. Run npm audit to check if it reports 0 vulnerabilities.
  4. Check if npm start, npm run dev, npm run build, and npm run lint:js work well.
  5. Go to the admin page of **WooCommerce > Settings > Integration > Google Analytics. Toggle the "Use Global Site Tag" checkbox to see if it can show/hide the "Set Domain Name" option.
  6. Follow the same test steps in Fix the JS exceptions and incorrect quantity value for checkout event tracking #343 to determine if the event tracking is sent with *Checkout block.

Changelog entry

  • Dev - Upgrade to Node.js 18.
  • Dev - Upgrade all NPM dev dependencies.

@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Dec 29, 2023
@eason9487 eason9487 requested a review from a team December 29, 2023 10:38
@eason9487 eason9487 self-assigned this Dec 29, 2023
"node": ">=12",
"npm": ">=6"
"node": ">=18",
"npm": ">=9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node v16 is still compatible and gives 0 issues as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to #345 (comment).

@puntope
Copy link
Contributor

puntope commented Dec 29, 2023

Hi @eason9487

Thanks for the work done, however I see Node v16 is still compatible so I wonder if we should allow that version in the engines.

@eason9487
Copy link
Member Author

Hi @puntope, thanks for the review.

however I see Node v16 is still compatible so I wonder if we should allow that version in the engines.

Node.js v16 has exceeded its end-of-life date, 11 Sep 2023, so there should be no need to keep v16.

@eason9487 eason9487 requested a review from puntope January 3, 2024 04:13
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Thanks @eason9487 for clarifying the npm v16 topic. This can be merged

@eason9487 eason9487 merged commit fdb9a70 into trunk Jan 4, 2024
3 checks passed
@eason9487 eason9487 deleted the dev/281-nodejs-18-and-bump-dev-deps branch January 4, 2024 02:44
@tomalec tomalec mentioned this pull request Jan 9, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Node 18
2 participants