Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node 18 #281

Closed
4 tasks
puntope opened this issue Jun 29, 2023 · 0 comments · Fixed by #345
Closed
4 tasks

Upgrade to Node 18 #281

puntope opened this issue Jun 29, 2023 · 0 comments · Fixed by #345
Assignees
@eason9487
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@puntope
Copy link
Contributor

puntope commented Jun 29, 2023

Details

This issue is for upgrading the Node version since 14 (current version) has reached the end of it’s security support period. Since we rely on WP and WC components we should probably follow along with the Gutenberg issue:

WordPress/gutenberg#48588

Their current plan is to jump to Node 18.

This issue will also be helpful to collect any blockers which might be preventing us from upgrading the Node version.

Describe the solution you'd like

Update to Node 18

Acceptance criteria

  • Node engines set to >= 18
  • .nvmrc set to v18
  • App compiles without errors with Node 18
  • JS tests run correctly without errors with Node 18
@puntope puntope added the type: enhancement The issue is a request for an enhancement. label Jun 29, 2023
@eason9487 eason9487 self-assigned this Dec 29, 2023
@eason9487 eason9487 mentioned this issue Dec 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eason9487 eason9487

Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
2 participants
@puntope @eason9487