Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add babel-loader to webpack CoreConfig #906

Merged
merged 1 commit into from Aug 23, 2019
Merged

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Aug 23, 2019

While testing #905 I noticed master is not working on IE11. This PR transpiles wc-blocks-settings with babel, so it it works again.

How to test the changes in this Pull Request:

With IE 11:

  1. Open any post with a WooCommerce Block and verify it doesn't crash with a JS error.
  2. Open the editor and verify you can add WooCommerce Blocks without JS errors.

@Aljullu Aljullu added status: needs review type: bug The issue/PR concerns a confirmed bug. skip-changelog PRs that you don't want to appear in the changelog. labels Aug 23, 2019
@Aljullu Aljullu added this to the 2.4 milestone Aug 23, 2019
@Aljullu Aljullu requested a review from a team August 23, 2019 15:56
@Aljullu Aljullu self-assigned this Aug 23, 2019
@Aljullu Aljullu added this to In Progress PRs (for automation purposes) in Isotope via automation Aug 23, 2019
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Glad you caught this, definitely my bad :|

@Aljullu Aljullu merged commit 420d834 into master Aug 23, 2019
Isotope automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 23, 2019
@Aljullu Aljullu deleted the fix/core-babel-loader branch August 23, 2019 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-changelog PRs that you don't want to appear in the changelog. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants