This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Upgrade wp-prettier to 2.6.2 and reformat the codebase #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontdevde
added
skip-changelog
Convert `ProductControl` to TypeScript eslint-disable-nex...Convert `ProductControl` to TypeScript eslint-disable-next-line @typescript-eslint/ban-ts-comment @ts-ignore
woocommerce-blocks/assets/js/blocks/featured-items/with-edit-mode.tsx Lines 103 to 117 in 0c4f115 🚀 This comment was generated by the automations bot based on a
|
Convert `ProductCategoryControl` to TypeScriptConvert `ProductCategoryControl` to TypeScript
woocommerce-blocks/assets/js/blocks/featured-items/with-edit-mode.tsx Lines 74 to 85 in 0c4f115 🚀 This comment was generated by the automations bot based on a
|
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
|
Size Change: 0 B Total Size: 865 kB ℹ️ View Unchanged
|
Aljullu
approved these changes
Jun 15, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: This PR aims to upgrade wp-prettier to 2.6.2 and reformats the codebase accordingly.
Context: While working on the block theme default styles project, I discovered a couple of files where the formatting was off and fixed that in a recent PR. I wondered how the formatting got through initially and, from there, went down a rabbit hole. I discovered several files with formatting/whitespace issues and initially started this PR to fix those. Then I noticed that in some areas, the formatting seemed off compared to what I had recently seen in Gutenberg and WooCommerce when working on the Elements API exploration...
Long story short, it turns out that the version of wp-prettier we're using in WooCommerce Blocks is quite a bit behind what Gutenberg and WooCommerce are using. I first wanted to bring the version up to par with what's being used there and then noticed that jsnajdr recently created this PR WordPress/gutenberg#40542 in Gutenberg to update wp-prettier to 2.6.2. It now got merged today.
So this PR does the same for WooCommerce Blocks.
Testing
Note: Using the
Hide whitespaceoption makes the Github Diff view more manageable.User Facing Testing
npm run reformat-files. There shouldn't be any unformatted files.Changelog