This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix wide appender buttons overlap in Cart & Checkout blocks in the Editor #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b41d7d.
…penders.
Removing InnerBlocks.ButtonBlockAppender from renderAppender = {InnerBlocks.ButtonBlockAppender } results in the black appender button beeing shown only when the block is selected, and we need the appender to be visible by default.
ralucaStan
added
type: bug
|
@gigitux I've also assigned you as this was affecting the Mini Cart as well and I've applied the fix there as well. It would be great if you could also take a look. |
|
Size Change: +101 B (0%) Total Size: 813 kB
ℹ️ View Unchanged
|
alexflorisca
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Look good, thanks @ralucaStan, let's keep an eye out on Gutenberg and see if they revert the absolute positioning in the future.
gigitux
approved these changes
Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this Gutenberg change all appender buttons have
position:absoluteresulting in layout changes for the wide appender button.Initially I've tried to remove the renderAppender prop from places like here so that the default black Add block button should be shown instead of the white one with black borders. That worked, but the button was visible only when the block was selected. We needed the appender buttons to be visible all the time.
I've decided to fix this in place via CSS, so that we have the old buttons working as before.
I’m doing some research, and it looks like the GB change made people unhappy, as it ruined their layouts as well. I’ve also added a comment, I hope they will only make the small black buttons absolute and let the others as before so that we can revert this change.
Fixes #5742
Screenshots
Testing
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Performance Impact
Changelog