-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crossplane-provider-gcp/1.2.0 package update #19633
base: main
Are you sure you want to change the base?
Conversation
octo-sts
bot
commented
May 16, 2024
Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
c923a06
to
586ce41
Compare
Signed-off-by: Sergio Gonzalez <sergio.alfredo@chainguard.dev>
Signed-off-by: user <workstation-work@chainguard-workstations.iam.gserviceaccount.com>
Signed-off-by: Sergio Gonzalez <156850285+sergio-chainguard@users.noreply.github.com>
crossplane-provider-gcp.yaml
Outdated
echo "Using up ${UP_VERSION}" | ||
- uses: patch | ||
with: | ||
# not working with UP_UPTEST_LOCAL variable in Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably worth mentioning what's not working, also any chance the reason it's not working is a genuine issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A change was made to the repository from which this package is obtained. The current package is installing UP version 0.28.0. We currently have the package around version 0.32.0, because of this the repository installer package looks for the version of UP that had previously been passed as an argument, however, it is looking for a version of a variable that does not exist in the current repository. Should I add the comment to the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to be more detail
A change was made to the repository link, version 0.28.0 is specifically used to build the package. When adding the Wolfi package it is in version 0.30.0 which causes problems with the repository variables, previously (the previous repository) the UP_VERSION variable was overwritten, in the current repository it causes a problem with the version in addition to being necessary Pass the variable UPTEST_LOCAL_VERSION which has the current value v0.12.0-9.gac371c9 which is not counted for version 0.30.0.
In addition to this, the repository installs version 0.28.0 which is compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PR for aws operator, patching this file it could be fixed.
Signed-off-by: user <workstation-work@chainguard-workstations.iam.gserviceaccount.com>