Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datadog-integrations-core #19515

Closed

Conversation

joshrwolf
Copy link
Contributor

the integrations components needed at runtime by datadog-agent

@joshrwolf joshrwolf force-pushed the datadog-integrations-core branch 3 times, most recently from c12bb83 to cb55ca8 Compare May 15, 2024 20:07
Signed-off-by: Josh Wolf <josh@wolfs.io>
Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ tar tvf packages/x86_64/datadog-integrations-core-7.53.0-r0.apk
drwxrwxr-x root/root         0 1969-12-31 19:00 usr/bin/__pycache__
-rw-rw-r-- root/root      3204 1969-12-31 19:00 usr/bin/__pycache__/jp.cpython-312.pyc
-rwxrwxr-x root/root       227 1969-12-31 19:00 usr/bin/ddtrace-run
-rwxrwxr-x root/root      1695 1969-12-31 19:00 usr/bin/jp.py
-rwxrwxr-x root/root       213 1969-12-31 19:00 usr/bin/jsonschema
-rwxrwxr-x root/root       233 1969-12-31 19:00 usr/bin/normalizer
-rwxrwxr-x root/root       214 1969-12-31 19:00 usr/bin/pyspnego-parse

There are differing levels of yuck there. The biggest is pycache dir in bin/.

Where we use the pip install approach, we really need to also use a virtual env.
You can see az.yaml for an example of what we're doing there.

@joshrwolf
Copy link
Contributor Author

closing this since I now realize this needs to be part of the main datadog-agent package (for datadog reasons)

@joshrwolf joshrwolf closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants