Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lame: add package #19276

Merged
merged 5 commits into from
May 21, 2024
Merged

lame: add package #19276

merged 5 commits into from
May 21, 2024

Conversation

lpcalisi
Copy link
Contributor

@lpcalisi lpcalisi commented May 14, 2024

add lame to add libmp3lame support to ffmpeg

Signed-off-by: Lucas Pablo Calisi <calisi.lucas@gmail.com>
Signed-off-by: Lucas Pablo Calisi <calisi.lucas@gmail.com>
@lpcalisi
Copy link
Contributor Author

@xnox lame have not any recent release for the last four years, but all main distros have it (ubuntu, alpine). What do you think about putting it on wolfi?

Signed-off-by: Lucas Pablo Calisi <calisi.lucas@gmail.com>
@lpcalisi
Copy link
Contributor Author

@smoser could you give your feedback here too? Thanks

smoser
smoser previously approved these changes May 20, 2024
Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the lint and lgtm.

Signed-off-by: Lucas Pablo Calisi <calisi.lucas@gmail.com>
@lpcalisi
Copy link
Contributor Author

fix the lint and lgtm.

thanks you!

@xnox
Copy link
Contributor

xnox commented May 21, 2024

The quality of this software is obviously degrading. On the other hand mp3 is still popular in the virtual voicemail settings. So on the balance, it is probably more useful to have in, than out.

@smoser smoser merged commit b466c27 into wolfi-dev:main May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants