Add ability to disable annotations including canvas appearance-data #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Beautiful work!
Some comments I have:
annotationModemust be documented.- Having more unit tests would be great. I'll gladly help out.
- This technically deprecates
renderFormsin favor of much more powerfulannotationMode, so renderForms is to be marked as deprecated (this one can be on me)
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
be758b5
to
1a9897f
Compare
wojtekmaj
force-pushed
the
main
branch
6 times, most recently
from
1f184c5
to
ef56712
Compare
wojtekmaj
force-pushed
the
main
branch
7 times, most recently
from
b14700a
to
416e96c
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
36a36d4
to
e249af6
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
d14ccb7
to
744f655
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
26a73cc
to
33ea5de
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
f5a9fd6
to
9243e45
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
fbeabf1
to
240150a
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
fc18d18
to
304893b
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
653aa2c
to
9bb8a85
Compare
wojtekmaj
force-pushed
the
main
branch
7 times, most recently
from
2d488c1
to
a077571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #963