Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable annotations including canvas appearance-data #968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuliya-ivaniukovich
Copy link

Closes #963

@wojtekmaj wojtekmaj self-requested a review March 23, 2022 08:03
Copy link
Owner

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work!

Some comments I have:

  1. annotationMode must be documented.
  2. Having more unit tests would be great. I'll gladly help out.
  3. This technically deprecates renderForms in favor of much more powerful annotationMode, so renderForms is to be marked as deprecated (this one can be on me)

@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 26a73cc to 33ea5de Compare March 8, 2023 12:49
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from fbeabf1 to 240150a Compare May 8, 2023 13:01
@wojtekmaj wojtekmaj force-pushed the main branch 6 times, most recently from d5c2c3b to f4d4d49 Compare May 8, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to disable annotations (including bboxes in canvas)
2 participants