Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean cancel #843

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Clean cancel #843

wants to merge 5 commits into from
+150 −7

Commits on Sep 7, 2021

  1. add test for Page outside Document

    konstantin.knuetel committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    9219bfd View commit details
    Browse the repository at this point in the history

  2. cancel <Page> load if <Document> destroyed 

    Don't call pdf.getPage() if Document is destroyed
    konstantin.knuetel committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    e1d7585 View commit details
    Browse the repository at this point in the history

  3. abort file load on document reload/unmount

    konstantin.knuetel committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    5bf5a11 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. change according to comments 

    - call onLoadError() with Error()
- inline if() for code consistency
    konstantin.knuetel committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    c091eba View commit details
    Browse the repository at this point in the history

  2. rename .abort() to .cancel()

    konstantin.knuetel committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f556d78 View commit details
    Browse the repository at this point in the history