Get rid of non-null assertion

wojtekmaj · Apr 17, 2024 · f64bdd1 · f64bdd1
1 parent 50fa88c
commit f64bdd1
Show file tree

Hide file tree

Showing 10 changed files with 40 additions and 10 deletions.
diff --git a/sample/create-react-app-5/public/index.html b/sample/create-react-app-5/public/index.html
@@ -6,6 +6,6 @@
     <title>react-pdf sample page</title>
   </head>
   <body>
-    <div id="react-root"></div>
+    <div id="root"></div>
   </body>
 </html>
diff --git a/sample/create-react-app-5/src/index.tsx b/sample/create-react-app-5/src/index.tsx
@@ -2,4 +2,10 @@ import { createRoot } from 'react-dom/client';
 
 import Sample from './Sample';
 
-createRoot(document.getElementById('react-root')!).render(<Sample />);
+const root = document.getElementById('root');
+
+if (!root) {
+  throw new Error('Could not find root element');
+}
+
+createRoot(root).render(<Sample />);
diff --git a/sample/parcel2/index.html b/sample/parcel2/index.html
@@ -6,7 +6,7 @@
     <title>react-pdf sample page</title>
   </head>
   <body>
-    <div id="react-root"></div>
+    <div id="root"></div>
     <script type="module" src="./index.tsx"></script>
   </body>
 </html>
diff --git a/sample/parcel2/index.tsx b/sample/parcel2/index.tsx
@@ -2,4 +2,10 @@ import { createRoot } from 'react-dom/client';
 
 import Sample from './Sample';
 
-createRoot(document.getElementById('react-root')!).render(<Sample />);
+const root = document.getElementById('root');
+
+if (!root) {
+  throw new Error('Could not find root element');
+}
+
+createRoot(root).render(<Sample />);
diff --git a/sample/vite/index.html b/sample/vite/index.html
@@ -6,7 +6,7 @@
     <title>react-pdf sample page</title>
   </head>
   <body>
-    <div id="react-root"></div>
+    <div id="root"></div>
     <script type="module" src="./index.tsx"></script>
   </body>
 </html>
diff --git a/sample/vite/index.tsx b/sample/vite/index.tsx
@@ -2,4 +2,10 @@ import { createRoot } from 'react-dom/client';
 
 import Sample from './Sample.js';
 
-createRoot(document.getElementById('react-root')!).render(<Sample />);
+const root = document.getElementById('root');
+
+if (!root) {
+  throw new Error('Could not find root element');
+}
+
+createRoot(root).render(<Sample />);
diff --git a/sample/webpack5/index.html b/sample/webpack5/index.html
@@ -6,6 +6,6 @@
     <title>react-pdf sample page</title>
   </head>
   <body>
-    <div id="react-root"></div>
+    <div id="root"></div>
   </body>
 </html>
diff --git a/sample/webpack5/index.tsx b/sample/webpack5/index.tsx
@@ -2,4 +2,10 @@ import { createRoot } from 'react-dom/client';
 
 import Sample from './Sample';
 
-createRoot(document.getElementById('react-root')!).render(<Sample />);
+const root = document.getElementById('root');
+
+if (!root) {
+  throw new Error('Could not find root element');
+}
+
+createRoot(root).render(<Sample />);
diff --git a/test/index.html b/test/index.html
@@ -6,7 +6,7 @@
     <title>react-pdf test page</title>
   </head>
   <body>
-    <div id="react-root"></div>
+    <div id="root"></div>
     <script type="module" src="./index.tsx"></script>
   </body>
 </html>
diff --git a/test/index.tsx b/test/index.tsx
@@ -3,7 +3,13 @@ import { createRoot } from 'react-dom/client';
 
 import Test from './Test.js';
 
-createRoot(document.getElementById('react-root')!).render(
+const root = document.getElementById('root');
+
+if (!root) {
+  throw new Error('Could not find root element');
+}
+
+createRoot(root).render(
   <StrictMode>
     <Test />
   </StrictMode>,