This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Add methods for deleting/clearing a single request only; add check_response parameter to wait_for_request #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR does two things:
First, it adds a
.clear_request_by_id(request_id)method to the storage classes, which allows deleting/clearing of a single request from the storage rather than deleting/clearing all at once. This method is available as.delete_request(request_id)in theInspectRequestsMixin(and thus the webdriver).Personally, I believe a more elegant solution would be changing
InspectRequestsMixin.requeststo return a custom class implementing__delitem__, which would allow us to usedel driver.requests[request_id]instead, but I am not sure if this would break compatibility for some users.Secondly, it exposes the
check_responseparameter of the.find()method of the storage asInspectRequestMixin.wait_for_requests(..., check_response=False), allowing users to wait for requests until a response is available.Additionally, test cases and documentation updates for these changes have been included.