Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

completely disable the use of selenium wire #275

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SunnyCapt
Copy link

close #274

seleniumwire/webdriver.py Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@wkeeling
Copy link
Owner

Many thanks for the PR! Yes having an option to disable Selenium Wire programmatically sounds like it could be useful. I've made a couple of comments and would be happy to merge if you're able to resolve.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #275 (4780272) into master (5f27924) will decrease coverage by 0.95%.
The diff coverage is 52.77%.

❗ Current head 4780272 differs from pull request most recent head 0d17d64. Consider uploading reports for the commit 0d17d64 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   86.04%   85.08%   -0.96%     
==========================================
  Files          13       13              
  Lines        1096     1120      +24     
==========================================
+ Hits          943      953      +10     
- Misses        153      167      +14     
Impacted Files Coverage Δ
seleniumwire/webdriver.py 39.65% <52.77%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f27924...0d17d64. Read the comment docs.

@SunnyCapt SunnyCapt requested a review from wkeeling April 28, 2021 22:30
@wkeeling
Copy link
Owner

wkeeling commented Apr 29, 2021

Thanks for making the changes - all looks good.

I've just run the code with undetected chromedriver and realized that we're going to need to wait for your other PR to get merged first, otherwise undetected chromedriver will raise:

TypeError: __init__() got an unexpected keyword argument 'chrome2use'

So once that undetected chromedriver PR is merged we're good to merge this one.

Thanks again!

@SunnyCapt
Copy link
Author

okay, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

completely disable the use of selenium wire
3 participants