Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unstake logic #2459

Open
wants to merge 3 commits into
base: 2.0-master
Choose a base branch
from
Open

Conversation

Tommytrg
Copy link
Member

@Tommytrg Tommytrg commented May 3, 2024

  • Implement unstaking logic
  • Implement unstake JSON-RPC method
  • Implement unstake CLI method

close #2450
close #2451
close #2452

@Tommytrg Tommytrg force-pushed the feat/unstake branch 2 times, most recently from e535f17 to c8f4db2 Compare May 3, 2024 16:15
@Tommytrg Tommytrg marked this pull request as ready for review May 15, 2024 17:14
}
}
Err(e) => {
log::error!("Failed to sign stake transaction: {}", e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log::error!("Failed to sign stake transaction: {}", e);
log::error!("Failed to sign unstake transaction: {}", e);

Comment on lines +221 to +222
let inputs =
self.take_enough_utxos(amount, timestamp, block_number_limit, utxo_strategy)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why caring about inputs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants